Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #156 - do not append unexpected trailing slashes to routes with… #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes #156 - do not append unexpected trailing slashes to routes with… #157

wants to merge 1 commit into from

Conversation

ergo
Copy link

@ergo ergo commented Dec 13, 2016

fixes #156 - do not append unexpected trailing slashes to routes with query params

@ergo
Copy link
Author

ergo commented Dec 13, 2016 •
edited
Loading

The tests pass here locally, something is wrong with travis setup? (maybe old nodejs version?)

@ergo
Copy link
Author

ergo commented Feb 28, 2017

@millermedeiros Can you pull in this PR?
This router has broken query string interpolation.

@zhang356
Copy link

Hi, can we merge this change in, I'm seeing same bug, really want this to be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing slashes are appended to routes that have query params
2 participants
@ergo @zhang356